raulcd commented on PR #107: URL: https://github.com/apache/iceberg-cpp/pull/107#issuecomment-2915302693
I am slightly confused, the log output from the job, see the artifact uploaded here: https://github.com/apache/iceberg-cpp/actions/runs/15293677546?pr=107 suggest there are several leaks, example: ``` Indirect leak of 31 byte(s) in 1 object(s) allocated from: #0 0x7f1fcbcfe548 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:95 #1 0x557a45d3e428 in std::__new_allocator<char>::allocate(unsigned long, void const*) /usr/include/c++/13/bits/new_allocator.h:151 #2 0x557a45cf56e5 in std::allocator<char>::allocate(unsigned long) /usr/include/c++/13/bits/allocator.h:198 #3 0x557a45cf56e5 in std::allocator_traits<std::allocator<char> >::allocate(std::allocator<char>&, unsigned long) /usr/include/c++/13/bits/alloc_traits.h:482 #4 0x557a45cf56e5 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_S_allocate(std::allocator<char>&, unsigned long) /usr/include/c++/13/bits/basic_string.h:126 #5 0x557a45cf3657 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_create(unsigned long&, unsigned long) /usr/include/c++/13/bits/basic_string.tcc:159 #6 0x557a45cf5196 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_mutate(unsigned long, unsigned long, char const*, unsigned long) /usr/include/c++/13/bits/basic_string.tcc:332 #7 0x557a45cddb0c in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_replace_aux(unsigned long, unsigned long, unsigned long, char) /usr/include/c++/13/bits/basic_string.tcc:468 #8 0x557a45e0eefd in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::append(unsigned long, char) /usr/include/c++/13/bits/basic_string.h:1488 #9 0x557a45e1ac3a in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::resize(unsigned long, char) /usr/include/c++/13/bits/basic_string.tcc:405 #10 0x557a45e1737f in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::resize(unsigned long) /usr/include/c++/13/bits/basic_string.h:1114 #11 0x557a465e9c49 in EncodeMetadata /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/vendoredarrow-src/cpp/src/arrow/c/bridge.cc:154 #12 0x557a465eb370 in ExportMetadata /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/vendoredarrow-src/cpp/src/arrow/c/bridge.cc:296 #13 0x557a465ea162 in ExportField /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/vendoredarrow-src/cpp/src/arrow/c/bridge.cc:189 #14 0x557a465eb1b2 in ExportChildren /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/vendoredarrow-src/cpp/src/arrow/c/bridge.cc:283 #15 0x557a465ea5cb in ExportSchema /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/vendoredarrow-src/cpp/src/arrow/c/bridge.cc:209 #16 0x557a465ed9db in arrow::ExportSchema(arrow::Schema const&, ArrowSchema*) /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/vendoredarrow-src/cpp/src/arrow/c/bridge.cc:523 #17 0x557a45c92944 in iceberg::FromArrowSchemaTest_StructType_Test::TestBody() /home/runner/work/iceberg-cpp/iceberg-cpp/test/arrow_test.cc:357 #18 0x557a46fb1d22 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/googletest-src/googletest/src/gtest.cc:2638 #19 0x557a46faac32 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/googletest-src/googletest/src/gtest.cc:2674 #20 0x557a46f85b37 in testing::Test::Run() /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/googletest-src/googletest/src/gtest.cc:2713 #21 0x557a46f865f5 in testing::TestInfo::Run() /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/googletest-src/googletest/src/gtest.cc:2859 #22 0x557a46f86fbd in testing::TestSuite::Run() /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/googletest-src/googletest/src/gtest.cc:3037 #23 0x557a46f96fe3 in testing::internal::UnitTestImpl::RunAllTests() /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/googletest-src/googletest/src/gtest.cc:5967 #24 0x557a46fb31a7 in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/googletest-src/googletest/src/gtest.cc:2638 #25 0x557a46fabeda in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/googletest-src/googletest/src/gtest.cc:2674 #26 0x557a46f954cf in testing::UnitTest::Run() /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/googletest-src/googletest/src/gtest.cc:5546 #27 0x557a45e51ea1 in RUN_ALL_TESTS() /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/googletest-src/googletest/include/gtest/gtest.h:2334 #28 0x557a45e51e89 in main /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/googletest-src/googletest/src/gtest_main.cc:64 #29 0x7f1fcac2a1c9 (/lib/x86_64-linux-gnu/libc.so.6+0x2a1c9) (BuildId: 42c84c92e6f98126b3e2230ebfdead22c235b667) #30 0x7f1fcac2a28a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2a28a) (BuildId: 42c84c92e6f98126b3e2230ebfdead22c235b667) #31 0x557a45c6a584 in _start (/home/runner/work/iceberg-cpp/iceberg-cpp/build/test/arrow_test+0x12ac584) (BuildId: a1cb9affe9505874d1d4ac3b05b928803d7bf509) ``` Shouldn't the CI job fail? I might be misinterpreting but I would expect the job to fail if a leak is found (as it seems is found from the logs) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
