pvary commented on code in PR #13127:
URL: https://github.com/apache/iceberg/pull/13127#discussion_r2106716484
##########
docs/docs/flink-writes.md:
##########
@@ -75,7 +75,7 @@ Iceberg supports `UPSERT` based on the primary key when
writing data into v2 tab
```
!!! info
- OVERWRITE and UPSERT can't be set together. In UPSERT mode, if the table
is partitioned, the partition fields should be included in equality fields.
+ OVERWRITE and UPSERT can't be set together. In UPSERT mode, if the table
is partitioned, the source columns of partition fields should be included in
equality fields. For partition field `days(ts)`, the source column `ts` should
be included in equality fields.
Review Comment:
Maybe:
> OVERWRITE and UPSERT modes are mutually exclusive and cannot be enabled at
the same time. When using UPSERT mode with a partitioned table, all of the
source columns corresponding to the partition fields must be included in the
equality fields. For example, if the partition field is `days(ts)`, then the id
of the column `ts` must be part of the equality fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
