pvary commented on code in PR #13127:
URL: https://github.com/apache/iceberg/pull/13127#discussion_r2104092388
##########
docs/docs/flink-writes.md:
##########
@@ -75,7 +75,7 @@ Iceberg supports `UPSERT` based on the primary key when
writing data into v2 tab
```
!!! info
- OVERWRITE and UPSERT can't be set together. In UPSERT mode, if the table
is partitioned, the partition fields should be included in equality fields.
+ OVERWRITE and UPSERT can't be set together. In UPSERT mode, if the table
is partitioned, the source columns of partition fields should be included in
equality fields.
Review Comment:
Could you please add an example like this to the doc?
Now, I understand what `source columns of` means. But I needed the example
to understand the exact meaning.
Thanks,
Peter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
