smaheshwar-pltr commented on code in PR #2031:
URL: https://github.com/apache/iceberg-python/pull/2031#discussion_r2102688184
##########
pyiceberg/table/__init__.py:
##########
@@ -1536,10 +1595,181 @@ def __init__(
self.row_filter = _parse_row_filter(row_filter)
self.selected_fields = selected_fields
self.case_sensitive = case_sensitive
- self.snapshot_id = snapshot_id
self.options = options
self.limit = limit
+ @abstractmethod
+ def projection(self) -> Schema: ...
+
+ @abstractmethod
+ def plan_files(self) -> Iterable[ScanTask]: ...
+
+ @abstractmethod
+ def to_arrow(self) -> pa.Table: ...
+
+ @abstractmethod
+ def count(self) -> int: ...
+
+ def select(self: S, *field_names: str) -> S:
+ if "*" in self.selected_fields:
+ return self.update(selected_fields=field_names)
+ return
self.update(selected_fields=tuple(set(self.selected_fields).intersection(set(field_names))))
+
+ def filter(self: S, expr: Union[str, BooleanExpression]) -> S:
+ return self.update(row_filter=And(self.row_filter,
_parse_row_filter(expr)))
+
+ def with_case_sensitive(self: S, case_sensitive: bool = True) -> S:
+ return self.update(case_sensitive=case_sensitive)
+
+ def update(self: S, **overrides: Any) -> S:
+ """Create a copy of this table scan with updated fields."""
+ return type(self)(**{**self.__dict__, **overrides})
+
+ def to_pandas(self, **kwargs: Any) -> pd.DataFrame:
Review Comment:
A minor user-facing change (IMHO) is that these methods on `TableScan` that
subclasses this now have default implementations based on the `to_arrow`
abstract method. This feels OK to me - its subclasses can override is needed,
but maybe should be documented (if we want to go with this approach).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
