smaheshwar-pltr commented on code in PR #2031:
URL: https://github.com/apache/iceberg-python/pull/2031#discussion_r2102680685
##########
pyiceberg/table/__init__.py:
##########
@@ -1507,16 +1566,17 @@ def _parse_row_filter(expr: Union[str,
BooleanExpression]) -> BooleanExpression:
return parser.parse(expr) if isinstance(expr, str) else expr
-S = TypeVar("S", bound="TableScan", covariant=True)
+S = TypeVar("S", bound="AbstractTableScan", covariant=True)
-class TableScan(ABC):
+class AbstractTableScan(ABC):
Review Comment:
Github's diff here is messed up.
A significant goal of this PR is to introduce *no* user-facing breaks (I
believe), which I am guessing was the main concern with
https://github.com/apache/iceberg-python/pull/533 that e.g. removed
`snapshot_id` from `TableScan`. In this PR, I keep that field - this means it
doesn't make sense for incremental scans to subclass `TableScan` because they
have two snapshot IDs.
I therefore introduced this abstract class to be a base class for all table
scans, non-incremental and incremental.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
