DerGut commented on code in PR #1368: URL: https://github.com/apache/iceberg-rust/pull/1368#discussion_r2102313677
########## crates/iceberg/src/io/mod.rs: ########## Review Comment: I did some reordering here. I felt like it was more obvious to separate the feature-flagged `mod` and `use` statements from the non-feature-flagged ones. The `#[cfg(...` lines made it easy for me to overlook that something non-integration related was declared (e.g. `pub(crate) mod object_cache;`). I also separated the feature-flagged `mod` and `use` statements. This allowed my IDE able to sort them, which I think makes sense with a growing number of storage integrations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
