jonathanc-n commented on code in PR #1172:
URL: https://github.com/apache/iceberg-rust/pull/1172#discussion_r2099265733


##########
crates/iceberg/src/spec/schema/mod.rs:
##########
@@ -21,6 +21,7 @@ use std::collections::{HashMap, HashSet};
 use std::fmt::{Display, Formatter};
 use std::sync::Arc;
 
+mod update;

Review Comment:
   No the folder gives context, so schema/update.rs -> updating schema. with 
transaction/update_statistics, there is no context given to what the file is 
doing if it is called statistics.rs, so update_statistics is fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to