CTTY commented on code in PR #1172:
URL: https://github.com/apache/iceberg-rust/pull/1172#discussion_r2099236486
##########
crates/iceberg/src/spec/schema/mod.rs:
##########
@@ -21,6 +21,7 @@ use std::collections::{HashMap, HashSet};
use std::fmt::{Display, Formatter};
use std::sync::Arc;
+mod update;
Review Comment:
I'm very new to rust naming convention, thanks for the context! In this
case, probably `schema.rs` is a better name?
I'm adding a new file `update_statistics.rs` under the same folder in this
PR: https://github.com/apache/iceberg-rust/pull/1359 I'll probably rename it to
`statistics.rs`, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
