pvary commented on code in PR #13080:
URL: https://github.com/apache/iceberg/pull/13080#discussion_r2098208762
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/DeltaManifestsSerializer.java:
##########
@@ -28,12 +28,12 @@
import org.apache.iceberg.ManifestFiles;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
-class DeltaManifestsSerializer implements
SimpleVersionedSerializer<DeltaManifests> {
+public class DeltaManifestsSerializer implements
SimpleVersionedSerializer<DeltaManifests> {
Review Comment:
Please mark all of the new public classes to `@Internal`. We use these Flink
annotations in the Iceberg connector extensively to limit the external API, and
allow us free hand on modifying most of the classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
