mxm commented on code in PR #13080:
URL: https://github.com/apache/iceberg/pull/13080#discussion_r2097969779
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/CommitSummary.java:
##########
@@ -19,13 +19,14 @@
package org.apache.iceberg.flink.sink;
import java.util.Arrays;
+import java.util.List;
import java.util.NavigableMap;
import java.util.concurrent.atomic.AtomicLong;
import org.apache.iceberg.io.WriteResult;
import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
import org.apache.iceberg.util.ScanTaskUtil;
-class CommitSummary {
+public class CommitSummary {
Review Comment:
Are you suggesting to annotate with `@Internal` because of the visibility
change?
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/RowDataTaskWriterFactory.java:
##########
@@ -148,6 +170,7 @@ public void initialize(int taskId, int attemptId) {
OutputFileFactory.builderFor(table, taskId, attemptId)
.format(format)
.ioSupplier(() -> tableSupplier.get().io())
+ .defaultSpec(spec)
Review Comment:
I don't think so. This field in the builder would normally be set to the
current table spec, but for the dynamic sink we can write multiple active
specs, for which we will have a dedicated writer each.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
