Guosmilesmile commented on code in PR #13024:
URL: https://github.com/apache/iceberg/pull/13024#discussion_r2093790184
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ExpireSnapshots.java:
##########
@@ -47,6 +47,11 @@ public static class Builder extends
MaintenanceTaskBuilder<ExpireSnapshots.Build
private Integer planningWorkerPoolSize;
private int deleteBatchSize = DELETE_BATCH_SIZE_DEFAULT;
+ @Override
+ String maintenanceTaskName() {
+ return "ExpireSnapshots";
+ }
Review Comment:
I think it is different. `maintenanceTaskName` describes the whole task
information to display in metrics, whereas `operatorName` only corresponds to
the names of sub-tasks like planner, rewrite, commit, and aggregator, and
cannot effectively represent the entire task name (as Peter mentioned,
`RewriteDataFiles` has multiple sub-operators).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
