pvary commented on code in PR #13024:
URL: https://github.com/apache/iceberg/pull/13024#discussion_r2084462417


##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/TableMaintenance.java:
##########
@@ -302,7 +302,10 @@ private DataStream<TableChange> changeStream(String 
tableName, TableLoader loade
 
     private static String nameFor(MaintenanceTaskBuilder<?> streamBuilder, int 
taskIndex) {
       return String.format(
-          Locale.ROOT, "%s [%d]", streamBuilder.getClass().getSimpleName(), 
taskIndex);
+          Locale.ROOT,
+          "%s [%d]",
+          streamBuilder.getClass().getEnclosingClass().getSimpleName(),

Review Comment:
   Could we add a method to the builder to return the name? I would prefer not 
to "hard-code" the requirement that the builder should have an enclosing class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to