jonathanc-n commented on code in PR #1299:
URL: https://github.com/apache/iceberg-rust/pull/1299#discussion_r2087291885
##########
crates/iceberg/src/spec/name_mapping/mod.rs:
##########
@@ -84,9 +133,187 @@ impl MappedField {
}
}
+/// Recursively visits the entire name mapping using visitor
+fn visit_name_mapping<V>(namespace: &Vec<Arc<MappedField>>, visitor: &V) ->
V::S
Review Comment:
This is because when creating a new `NameMapping` we call `visit_schema`
which creates an array of mapped fields which are then called on by
`index_by_id` + `index_by_name`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
