jonathanc-n commented on code in PR #1299:
URL: https://github.com/apache/iceberg-rust/pull/1299#discussion_r2078283965
##########
crates/iceberg/src/spec/name_mapping/mod.rs:
##########
@@ -55,7 +96,7 @@ pub struct MappedField {
#[serde(default)]
#[serde(skip_serializing_if = "Vec::is_empty")]
#[serde_as(deserialize_as = "DefaultOnNull")]
- fields: Vec<Arc<MappedField>>,
+ fields: Vec<MappedField>,
Review Comment:
No need for arc here, the mapping is created once + there won't be a time
where more than one thread is accessing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
