nastra commented on code in PR #12901:
URL: https://github.com/apache/iceberg/pull/12901#discussion_r2086051251


##########
nessie/src/test/java/org/apache/iceberg/nessie/TestBranchVisibility.java:
##########
@@ -455,7 +456,9 @@ public void testWithRefAndHash() throws 
NessieConflictException, NessieNotFoundE
     String hashBeforeNamespaceCreation = 
api.getReference().refName(testBranch).get().getHash();
     Namespace namespaceA = Namespace.of("a");
     Namespace namespaceAB = Namespace.of("a", "b");
-    assertThat(nessieCatalog.listNamespaces(namespaceAB)).isEmpty();
+    NessieCatalog finalNessieCatalog = nessieCatalog;

Review Comment:
   I would rather store the other catalog that re-initializes `nessieCatalog` 
further below in a separate variable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to