tomtongue commented on code in PR #13016:
URL: https://github.com/apache/iceberg/pull/13016#discussion_r2081975653
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergSink.java:
##########
@@ -421,8 +421,10 @@ void testOperatorsUidNameWitUidSuffix() throws Exception {
@TestTemplate
void testErrorOnNullForRequiredField() throws Exception {
- Assume.assumeFalse(
- "ORC file format supports null values even for required fields.",
format == FileFormat.ORC);
+
+ assumeThat(format)
+ .as("ORC file format supports null values even for required
fields.")
+ .isEqualTo(FileFormat.ORC);
Review Comment:
The current one uses `assumeFalse` to omit tests for ORC, so use
`isNotEqualTo`, not `isEqualTo`
```suggestion
assumeThat(format)
.as("ORC file format supports null values even for required fields.")
.isNotEqualTo(FileFormat.ORC);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
