jagdeeps91 commented on PR #1285: URL: https://github.com/apache/iceberg-rust/pull/1285#issuecomment-2851945848
@kevinjqliu Actually after reading Java code I think we should allow Void Transform on any type to be compatible with iceberg-java: https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/PartitionSpec.java#L635 Since Transform should only return Primitive Types, I can change the code here to always return Ok(None) https://github.com/apache/iceberg-rust/blame/main/crates/iceberg/src/transform/void.rs#L28 I dont think Void returning array is correct. I can still refactor this code to optimize the `check_transform_compatibility` and remove the check outside this function. Let me know what you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
