dentiny opened a new pull request, #1301: URL: https://github.com/apache/iceberg-rust/pull/1301
## What changes are included in this PR? The general usage to append data files is ```rust let mut action = txn.fast_append(/*commit_uuid=*/ None, /*key_metadata=*/ vec![])?; action.add_data_files(new_data_files)?; let txn = action.apply().await?; let table = txn.commit(catalog).await? ``` I found if ` new_data_files` is empty by accident, a new manifest file will still be created and tracked by manifest list file, which doesn't make sense to me (let me if team thinks it's a valid and ideal use case). In this PR, I did a few changes: - Add a new invalid argument error code; - Add assertion to fail empty data files append, and empty action commit use cases. ## Are these changes tested? Existing unit tests pass, and add a validation test for invalid data file append. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
