nastra commented on code in PR #12670:
URL: https://github.com/apache/iceberg/pull/12670#discussion_r2081029224


##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1450,6 +1452,10 @@ private Builder 
rewriteSnapshotsInternal(Collection<Long> idsToRemove, boolean s
         }
       }
 
+      if (!snapshotIdsToRemove.isEmpty()) {
+        changes.add(new MetadataUpdate.RemoveSnapshots(snapshotIdsToRemove));

Review Comment:
   @ajantha-bhat the `MetadataUpdateParser` will still send a `RemoveSnapshot` 
for a single element for older clients



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to