xiaoxuandev commented on code in PR #12868:
URL: https://github.com/apache/iceberg/pull/12868#discussion_r2080374719
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SerializableTableWithSize.java:
##########
@@ -65,8 +66,7 @@ public static Table copyOf(Table table) {
@Override
public void close() throws Exception {
if (serializationMarker == null) {
- LOG.info("Releasing resources");
- io().close();
+ LOG.info("Executor-side cleanup: closing deserialized table resources");
Review Comment:
@nastra Yeah, I agree, at least for `S3FileIO`, `ApacheHttpClient` is the
recommended and default HTTP client. That said, other FileIO implementations
might also use `ApacheHttpClient`. We're also not entirely sure whether other
HttpClient implementations adopt the same shared connection pool model, though
using a shared pool does seem like a reasonable approach to avoid resource
leaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
