nastra commented on code in PR #12868:
URL: https://github.com/apache/iceberg/pull/12868#discussion_r2079813084
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SerializableTableWithSize.java:
##########
@@ -65,8 +66,7 @@ public static Table copyOf(Table table) {
@Override
public void close() throws Exception {
if (serializationMarker == null) {
- LOG.info("Releasing resources");
- io().close();
+ LOG.info("Executor-side cleanup: closing deserialized table resources");
Review Comment:
I'm not sure that the best approach is to just not close the FileIO instance
in general because other FileIO implementations might not be using shared
connections and such. I think we should rather then handle the issue within the
affected FileIO implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
