zeroshade commented on code in PR #414:
URL: https://github.com/apache/iceberg-go/pull/414#discussion_r2080217572


##########
catalog/sql/sql.go:
##########
@@ -147,6 +149,19 @@ type sqlIcebergNamespaceProps struct {
        PropertyValue sql.NullString
 }
 
+type sqlIcebergView struct {
+       bun.BaseModel `bun:"table:iceberg_views"`
+
+       CatalogName              string `bun:",pk"`
+       ViewNamespace            string `bun:",pk"`
+       ViewName                 string `bun:",pk"`
+       ViewSQL                  string
+       SchemaJSON               string
+       MetadataLocation         sql.NullString
+       PreviousMetadataLocation sql.NullString
+       Properties               map[string]string `bun:",json"`

Review Comment:
   is this the same schema used by the JDBC/other sql based catalogs?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to