ajantha-bhat commented on PR #12629:
URL: https://github.com/apache/iceberg/pull/12629#issuecomment-2863113599

   > About the full_compute => true param, could you help what would be the 
user motivation of calling this version of the procedure? 
   
   Maybe previous/current stats file is corrupted or some optional fields was 
not computed. User can use this. 
   
   > We might not want to expose 
PartitionStatsHandler.computeAndWriteStatsFileIncremental() as public
   
   I am envisioning two interfaces (because Iceberg has 
[guidelines](https://iceberg.apache.org/contribute/?h=contri#boolean-arguments) 
that we can't use boolean in public interface).
   
   
   `PartitionStatsHandler.computeAndWriteStats()` -- incrementally compute 
stats if previous stats available, if not full compute.
   
   `PartitionStatsHandler.computeAndWriteStatsFullRefresh() `-- Forcefully 
compute the stats (without considering pervious stats) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to