pvary commented on PR #12629: URL: https://github.com/apache/iceberg/pull/12629#issuecomment-2841715415
> But we need to test parquet aswell. And I didn't see any test in core with InternalData and Parquet. Since parquet is expected to be added at the runtime dependency it will work in production. I am not sure, how are we gonna add test in core module for it as it is a circular dependency. If there is no current infrastructure for this, then I would create a base test class which contains the methods, and in the avro/parquet package we can extend the class to run the tests using the specific file format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
