pvary commented on code in PR #12254:
URL: https://github.com/apache/iceberg/pull/12254#discussion_r2079342904
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -107,9 +107,16 @@ public abstract class TestRemoveOrphanFilesAction extends
TestBase {
protected Map<String, String> properties;
@Parameter private int formatVersion;
- @Parameters(name = "formatVersion = {0}")
+ @Parameter(index = 1)
+ private boolean usePrefixList;
+
+ @Parameters(name = "formatVersion = {0}, usePrefixList = {1}")
protected static List<Object> parameters() {
- return Arrays.asList(2, 3);
+ return Arrays.asList(
+ new Object[] {2, true},
+ new Object[] {3, true},
+ new Object[] {2, false},
+ new Object[] {3, false});
Review Comment:
Do we need a full set of tests? These tests are costly, and running them
might not be needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
