nastra commented on code in PR #12984:
URL: https://github.com/apache/iceberg/pull/12984#discussion_r2076845190


##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java:
##########
@@ -98,7 +99,7 @@ public AwsClientProperties() {
   }
 
   public AwsClientProperties(Map<String, String> properties) {
-    this.allProperties = SerializableMap.copyOf(properties);
+    this.allProperties = new HashMap<>(properties);

Review Comment:
   in fact we're using `SerializableMap` mainly due to Kryo ser/de so I'm 
surprised that this would fix the issue. Can you please add a test to 
`TestS3FileIO` that reproduces the issue you're running into?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to