singhpk234 commented on code in PR #12984:
URL: https://github.com/apache/iceberg/pull/12984#discussion_r2076548312
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java:
##########
@@ -98,7 +99,7 @@ public AwsClientProperties() {
}
public AwsClientProperties(Map<String, String> properties) {
- this.allProperties = SerializableMap.copyOf(properties);
+ this.allProperties = new HashMap<>(properties);
Review Comment:
This would serializableMap itself is not kryo serializable ? hmm which can
break other things ?
how about adding a test to this meanwhile there are KryoSerde Test in
S3FileIO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
