RussellSpitzer commented on code in PR #12494: URL: https://github.com/apache/iceberg/pull/12494#discussion_r2075844103
########## settings.gradle: ########## @@ -161,6 +161,18 @@ if (sparkVersions.contains("3.5")) { project(":iceberg-spark:spark-runtime-3.5_${scalaVersion}").name = "iceberg-spark-runtime-3.5_${scalaVersion}" } +if (sparkVersions.contains("4.0")) { + include ":iceberg-spark:spark-4.0_2.13" Review Comment: Doesn't that mean when Scala is set to 2.12 we just should allow building Spark 4.0? ########## settings.gradle: ########## @@ -161,6 +161,18 @@ if (sparkVersions.contains("3.5")) { project(":iceberg-spark:spark-runtime-3.5_${scalaVersion}").name = "iceberg-spark-runtime-3.5_${scalaVersion}" } +if (sparkVersions.contains("4.0")) { + include ":iceberg-spark:spark-4.0_2.13" Review Comment: Doesn't that mean when Scala is set to 2.12 we just should not allow building Spark 4.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org