RussellSpitzer commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2075822117


##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java:
##########
@@ -875,7 +875,13 @@ private static void deleteManifests(FileIO io, 
List<ManifestFile> manifests) {
   public static Dataset<Row> loadTable(SparkSession spark, Table table, long 
snapshotId) {
     SparkTable sparkTable = new SparkTable(table, snapshotId, false);
     DataSourceV2Relation relation = createRelation(sparkTable, 
ImmutableMap.of());
-    return Dataset.ofRows(spark, relation);
+    if (!(spark instanceof org.apache.spark.sql.classic.SparkSession)) {

Review Comment:
   I think I noted other places, but let's change all of these checks to a 
Precondition if we can



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to