hsingh574 commented on code in PR #12855:
URL: https://github.com/apache/iceberg/pull/12855#discussion_r2074204743
##########
data/src/test/java/org/apache/iceberg/data/TestGenericReaderDeletes.java:
##########
@@ -47,12 +48,13 @@ protected void dropTable(String name) {
@Override
public StructLikeSet rowSet(String name, Table table, String... columns)
throws IOException {
- StructLikeSet set = StructLikeSet.create(table.schema().asStruct());
Review Comment:
This was needed when introducing new optional columns to the schema because
`Iterators.addAll` needs to do a hashCode calculation which ends up looking for
a value at every position in the schema, and the optional column values don't
exist for the other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
