RussellSpitzer commented on code in PR #12855:
URL: https://github.com/apache/iceberg/pull/12855#discussion_r2074051039


##########
core/src/main/java/org/apache/iceberg/data/GenericRecord.java:
##########
@@ -134,6 +135,32 @@ public GenericRecord copy() {
     return new GenericRecord(this);
   }
 
+  @Override
+  public GenericRecord deepCopyValues() {
+    GenericRecord copy = new GenericRecord(this);
+    for (int i = 0; i < values.length; i++) {
+      copy.values[i] = deepCopyValue(values[i]);
+    }
+    return copy;
+  }
+
+  // This is currently scoped to types that were
+  // causing issues for equality deletes in
+  // https://github.com/apache/iceberg/issues/11239
+  private Object deepCopyValue(Object value) {
+    if (value instanceof ByteBuffer) {

Review Comment:
   ByteBuffers.copy



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to