alamb commented on code in PR #1293:
URL: https://github.com/apache/iceberg-rust/pull/1293#discussion_r2074008203
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -1029,6 +1030,7 @@ mod tests {
Arc::new(simple_field(DEFAULT_MAP_FIELD_NAME, r#struct, false,
"17")),
false,
);
+ let dictionary = DataType::Dictionary(Box::new(DataType::Int32),
Box::new(DataType::Utf8));
Review Comment:
I also recommend adding a test with a different combination as well (Int8
keys and UInt64 values, for example) to show this isn't just for Utf8 values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
