jdockerty opened a new pull request, #1293:
URL: https://github.com/apache/iceberg-rust/pull/1293

   
   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   - Closes https://github.com/apache/iceberg-rust/issues/1277
   
   ## What changes are included in this PR?
   
   An expansion to the current schema conversion for arrow to an iceberg schema.
   
   This uses the suggestion provided by @alamb 
([here](https://github.com/apache/iceberg-rust/issues/1277#issuecomment-2845952969))
 for the schema conversion work.
   
   <!--
   Provide a summary of the modifications in this PR. List the main changes 
such as new features, bug fixes, refactoring, or any other updates.
   -->
   
   ## Are these changes tested?
   
   The current test for schema conversion has been expanded.
   
   I've also taken the liberty of altering the `assert_eq!` call to use the 
`pretty_assertions` version, as it makes viewing the failure much simpler with 
a large JSON structure - I can revert this though if it problematic.
   
   <!--
   Specify what test covers (unit test, integration test, etc.).
   
   If tests are not included in your PR, please explain why (for example, are 
they covered by existing tests)?
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to