zeroshade commented on issue #386: URL: https://github.com/apache/iceberg-go/issues/386#issuecomment-2848127696
> Slight aside: I would also really love to see a top-level function that accepts an io.Reader for this, parallel to the existing ReadManifestList. I can file that as a separate issue if preferred. It feels missing, from a consistency point of view, but it would also be of value to me. (In the application I work on, we have a separate abstraction for accessing the object store -- with lots of bells and whistles for such as custom-configured HTTP client, metrics. and retries/hedging -- and it's much easier to use that and provide io.Reader values to the Iceberg library.) At some point I need to get around to creating a registry for the `io` interfaces in `iceberg/io` so that you'd be able to easily wrap/provide your own implementation for the FS stuff that gets used by the transactions and table operations... that would solve your problem haha. At the moment, if you look at the PR I filed, in theory you'd only need to have some object which implements `Open` and `Remove` functions to meet the `iceberg/io.IO` interface to return the reader. But I agree that, from a consistency point of view, it would make sense to have a `ReadManifest` function that takes an `io.Reader`. > FWIW, I could also put up a PR for this if this is something you choose not to prioritize. (Thanks for the conversation and consideration!) Feel free to either build off my PR (#415) or file your own PR for it and tag me! Thanks for the assistance here! I definitely want to do what I can to ensure that this library works for your use case :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
