jhump commented on issue #386: URL: https://github.com/apache/iceberg-go/issues/386#issuecomment-2848101826
> Despite everything above, I think it would be perfectly reasonable to add a method to ManifestFile which just reads and returns the Avro Metadata for the given manifest file. 😄 My primary objection honestly is simply that I think it would be misleading and dangerous to connect a particular schema ID directly to the ManifestEntry itself since it's not really representative of anything but the table schema at the time a particular manifest is written. Alright, that's totally fair. So the schema ID is associated with a manifest file, not particular entries. I think I may have drawn some incorrect links/conclusions from a read of the spec, because for some reason I had it in my head that manifests should be segmented by schema and partition spec. But I guess they are only segmented by partition spec. I would still find it very valuable to have this accessor for a manifest file, and even to have it for the very reasons I already discussed: the application I am working on generates the table and "owns" all of the files and manifests, and will segment manifests by schema ID to make numerous maintenance operations more efficient. So Iceberg-aware applications have read-only access to the table but should never write to it (only the application can write to it). This means the application can make some additional assumptions about the layout of manifests and data files (even if those assumptions might be horribly wrong for working with Iceberg tables generated by different systems). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
