nastra commented on code in PR #12162:
URL: https://github.com/apache/iceberg/pull/12162#discussion_r2068401074


##########
format/spec.md:
##########
@@ -742,6 +743,7 @@ A snapshot consists of the following fields:
 | _optional_ | _required_ | _required_ | **`summary`**                | A 
string map that summarizes the snapshot changes, including `operation` as a 
_required_ field (see below)                         |
 | _optional_ | _optional_ | _optional_ | **`schema-id`**              | ID of 
the table's current schema when the snapshot was created                        
                                             |
 |            |            | _required_ | **`first-row-id`**           | The 
first `_row_id` assigned to the first row in the first data file in the first 
manifest, see [Row Lineage](#row-lineage)        |
+|            |            | _optional_ | **`key-id`**                 | ID of 
the encryption key that encrypts the manifest list key metadata |

Review Comment:
   would it make sense to name this `encryption-key-id` to make it more obvious 
that this is about encryption



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to