rdblue commented on code in PR #12162:
URL: https://github.com/apache/iceberg/pull/12162#discussion_r2067181649


##########
format/spec.md:
##########
@@ -889,6 +890,7 @@ Table metadata consists of the following fields:
 | _optional_ | _optional_ | _optional_ | **`partition-statistics`**  | A list 
(optional) of [partition statistics](#partition-statistics).                    
                                                                                
                                                                                
                                                                                
                                                          |
 |            |            | _optional_ | **`row-lineage`**           | A 
boolean, defaulting to false, setting whether or not to track the creation and 
updates to rows in the table. See [Row Lineage](#row-lineage).                  
                                                                                
                                                                                
                                                                |
 |            |            | _optional_ | **`next-row-id`**           | A 
`long` higher than all assigned row IDs; the next snapshot's `first-row-id`. 
See [Row Lineage](#row-lineage).                                                
                                                                                
                                                                                
                                                                  |
+|            |            | _optional_ | **`current-key-id`**        | ID of 
the encryption key that encrypts the manifest list key metadata.                
                                                                                
                                                                                
                                                                                
                  |

Review Comment:
   Sorry, my comment was based on thinking this was a snapshot's key ID because 
of the description. This was actually in table metadata.
   
   Can we trust table metadata to provide a key ID to use? I would probably 
have the encryption manager select the key automatically -- the one that is 
available from KMS.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to