ebyhr commented on code in PR #12894: URL: https://github.com/apache/iceberg/pull/12894#discussion_r2068150946
########## docs/docs/aws.md: ########## @@ -84,7 +84,7 @@ With those dependencies, you can create a Flink catalog like the following: CREATE CATALOG my_catalog WITH ( 'type'='iceberg', 'warehouse'='s3://my-bucket/my/key/prefix', - 'type'='glue', + 'catalog-impl'='org.apache.iceberg.aws.glue.GlueCatalog', Review Comment: It might be better to use `catalog-type` instead. I’d imagine most people prefer shorter names -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
