ebyhr commented on code in PR #12894: URL: https://github.com/apache/iceberg/pull/12894#discussion_r2059691717
########## docs/docs/aws.md: ########## @@ -84,7 +84,7 @@ With those dependencies, you can create a Flink catalog like the following: CREATE CATALOG my_catalog WITH ( 'type'='iceberg', 'warehouse'='s3://my-bucket/my/key/prefix', - 'type'='glue', + 'catalog-type'='glue', Review Comment: The following yml uses `catalog-impl` property. Does it make sense to change the example too? Readers may wonder why different styles are used in these examples. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org