ajantha-bhat commented on code in PR #12912:
URL: https://github.com/apache/iceberg/pull/12912#discussion_r2066892520
##########
core/src/main/java/org/apache/iceberg/io/StorageCredential.java:
##########
@@ -29,18 +29,27 @@ public interface StorageCredential extends Serializable {
String prefix();
- SerializableMap<String, String> config();
+ /**
+ * @deprecated since 1.10.0, will be removed in 1.11.0; use {@link
#serializableConfig()} instead.
+ */
+ @Deprecated
+ default Map<String, String> config() {
+ return serializableConfig();
+ }
+
+ SerializableMap<String, String> serializableConfig();
Review Comment:
It is not breaking as we deprecate the old interface and adding new
interface here. But yeah, revAPI considers new interface addition also as a
breaking change.
I like your approach in #12930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
