nastra commented on PR #12912: URL: https://github.com/apache/iceberg/pull/12912#issuecomment-2837694580
> Let me add that I feel like we're working around Immutables here. The interface itself should be fine with Map<>. Is there a way to tell Immmutables to use a specific concrete implementation or is that not supported? > > It may be moot since the release has already passed, but we could always fix this and make the interface represent the original type. The underlying issue is that Immutables will always create an unmodifiable Map when the API definition is `Map<String, String>`, which Kryo can't deal with, since Kryo adds back elements to the collection after deserialization. There is some hope that Kryo will eventually be able to deal with unmodifiable collections without having to use a separate kryo-serializers lib (https://github.com/EsotericSoftware/kryo/pull/1154) but we're not there yet and maybe the better option would have been to not make `StorageCredential` use Immutables in the first place due to Kryo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
