amogh-jahagirdar commented on code in PR #12928:
URL: https://github.com/apache/iceberg/pull/12928#discussion_r2066616375
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/data/TestHelpers.java:
##########
@@ -115,22 +116,38 @@ public static void assertEqualsSafe(Types.StructType
struct, Record rec, Row row
public static void assertEqualsBatch(
Types.StructType struct, Iterator<Record> expected, ColumnarBatch batch)
{
- for (int rowId = 0; rowId < batch.numRows(); rowId++) {
- InternalRow row = batch.getRow(rowId);
- Record rec = expected.next();
+ assertEqualsBatch(struct, expected, batch, null, null);
+ }
+
+ public static void assertEqualsBatch(
+ Types.StructType struct,
+ Iterator<Record> expected,
+ ColumnarBatch batch,
+ Integer numRowsRead,
+ Map<Integer, Object> idToConstant) {
+ for (int rowPos = 0; rowPos < batch.numRows(); rowPos++) {
+ InternalRow row = batch.getRow(rowPos);
+ Record expectedRecord = expected.next();
Review Comment:
These changes should no longer be needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
