amogh-jahagirdar commented on code in PR #12928:
URL: https://github.com/apache/iceberg/pull/12928#discussion_r2066607495
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/data/GenericsHelpers.java:
##########
@@ -70,6 +72,19 @@ public static void assertEqualsSafe(Types.StructType struct,
Record expected, Ro
}
}
+ public static void assertEqualsBatch(
+ Types.StructType struct,
+ Iterator<Record> expectedRecords,
+ ColumnarBatch batch,
+ Map<Integer, Object> idToConstant,
+ Integer numRowsAlreadyRead) {
Review Comment:
I'm looking into cleaning this up, I needed to pass the number of rows
already read by the vectorized reader since that's needed to determine the
overall row position
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
