amogh-jahagirdar commented on code in PR #12925:
URL: https://github.com/apache/iceberg/pull/12925#discussion_r2066500326
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/data/parquet/vectorized/TestParquetDictionaryEncodedVectorizedReads.java:
##########
@@ -92,19 +94,16 @@ public void testMixedDictionaryNonDictionaryReads() throws
IOException {
Schema schema = new Schema(SUPPORTED_PRIMITIVES.fields());
File dictionaryEncodedFile = File.createTempFile("junit", null,
temp.toFile());
assertThat(dictionaryEncodedFile.delete()).as("Delete should
succeed").isTrue();
- Iterable<GenericData.Record> dictionaryEncodableData =
- RandomData.generateDictionaryEncodableData(
- schema, 10000, 0L, RandomData.DEFAULT_NULL_PERCENTAGE);
- try (FileAppender<GenericData.Record> writer =
- getParquetWriter(schema, dictionaryEncodedFile)) {
+ Iterable<Record> dictionaryEncodableData =
+ RandomGenericData.generateDictionaryEncodableRecords(schema, 10000,
0L);
+ try (FileAppender<Record> writer = getParquetWriter(schema,
dictionaryEncodedFile)) {
writer.addAll(dictionaryEncodableData);
}
File plainEncodingFile = File.createTempFile("junit", null, temp.toFile());
assertThat(plainEncodingFile.delete()).as("Delete should
succeed").isTrue();
- Iterable<GenericData.Record> nonDictionaryData =
- RandomData.generate(schema, 10000, 0L,
RandomData.DEFAULT_NULL_PERCENTAGE);
- try (FileAppender<GenericData.Record> writer = getParquetWriter(schema,
plainEncodingFile)) {
+ Iterable<Record> nonDictionaryData = RandomGenericData.generate(schema,
10000, 0L);
Review Comment:
This code used to pass in an explicit null percentage of 5% as an explicit
value to the generation function. Since 5% is already the default when it's not
specified, I made the change to just call the utility without an explicit null
percentage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
