amogh-jahagirdar commented on code in PR #12925:
URL: https://github.com/apache/iceberg/pull/12925#discussion_r2066483188
##########
data/src/test/java/org/apache/iceberg/data/TestLocalScan.java:
##########
@@ -263,9 +264,16 @@ public void testRandomData() throws IOException {
append.commit();
- Set<Record> records = Sets.newHashSet(IcebergGenerics.read(table).build());
+ Comparator<Record> recordComparator =
+ Comparator.comparing((Record r) -> r.get(0, Long.class))
+ .thenComparing(
+ (Record r) -> r.get(1, String.class),
Comparator.nullsFirst(String::compareTo));
+ List<Record> records =
Lists.newArrayList(IcebergGenerics.read(table).build());
+
+ expected.sort(recordComparator);
+ records.sort(recordComparator);
Review Comment:
See https://github.com/apache/iceberg/pull/12925#discussion_r2065200539 for
why I changed this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
