pvary commented on code in PR #12771:
URL: https://github.com/apache/iceberg/pull/12771#discussion_r2066262474
##########
docs/docs/configuration.md:
##########
@@ -52,6 +52,8 @@ Iceberg tables support table properties to configure table
behavior, like the de
| write.parquet.bloom-filter-enabled.column.col1 | (not set)
| Hint to parquet to write a bloom filter for the column: 'col1'
|
| write.parquet.bloom-filter-max-bytes | 1048576 (1 MB)
| The maximum number of bytes for a bloom filter bitset
|
| write.parquet.bloom-filter-fpp.column.col1 | 0.01
| The false positive probability for a bloom filter applied to 'col1'
(must > 0.0 and < 1.0)
|
+| write.parquet.stats-enabled.default | true
| Controls whether to collect parquet column statistics when not
specified on column level, can be configured to false with
[parquet-java#3189](https://github.com/apache/parquet-java/issues/3188) |
Review Comment:
I have some concerns with this one.
The Parquet version is defined by Iceberg. So this one will not work until a
new version of Parquet is released and we update our dependency. Users can't
use this config yet.
Maybe we should just avoid adding it until the new Parquet dependency
introduced? And then we can add the test and add the configuration description
as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
