dramaticlly commented on code in PR #12771:
URL: https://github.com/apache/iceberg/pull/12771#discussion_r2055106896
##########
docs/docs/configuration.md:
##########
@@ -52,6 +52,8 @@ Iceberg tables support table properties to configure table
behavior, like the de
| write.parquet.bloom-filter-enabled.column.col1 | (not set)
| Hint to parquet to write a bloom filter for the column: 'col1'
|
| write.parquet.bloom-filter-max-bytes | 1048576 (1 MB)
| The maximum number of bytes for a bloom filter bitset
|
| write.parquet.bloom-filter-fpp.column.col1 | 0.01
| The false positive probability for a bloom filter applied to 'col1'
(must > 0.0 and < 1.0)
|
+| write.parquet.stats-enabled.default | true
| Controls whether to collect parquet column statistics when not
specified on column level, currently not configurable
[parquet-java#3189](https://github.com/apache/parquet-java/issues/3188) |
Review Comment:
nit: `Default to collect all column statistics in the table. Can disable
after [parquet-java#3189](https://github.com/apache/parquet-java/issues/3188)`
or maybe mention the next parquet release version will be helpful?
##########
docs/docs/configuration.md:
##########
@@ -52,6 +52,8 @@ Iceberg tables support table properties to configure table
behavior, like the de
| write.parquet.bloom-filter-enabled.column.col1 | (not set)
| Hint to parquet to write a bloom filter for the column: 'col1'
|
| write.parquet.bloom-filter-max-bytes | 1048576 (1 MB)
| The maximum number of bytes for a bloom filter bitset
|
| write.parquet.bloom-filter-fpp.column.col1 | 0.01
| The false positive probability for a bloom filter applied to 'col1'
(must > 0.0 and < 1.0)
|
+| write.parquet.stats-enabled.default | true
| Controls whether to collect parquet column statistics when not
specified on column level, currently not configurable
[parquet-java#3189](https://github.com/apache/parquet-java/issues/3188) |
+| write.parquet.stats-enabled.column.col1 | (not set)
| Controls whether to collect parquet column statistics for column
'col1'; true or false
|
Review Comment:
we can probably remove `true or false` at the end, similar to other boolean
typed table properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
