liurenjie1024 commented on issue #1270: URL: https://github.com/apache/iceberg-rust/issues/1270#issuecomment-2837538361
>Since https://github.com/apache/iceberg-rust/pull/1266 is a bug fix, is it possible to add a unit test / integration test, which fails before the change, but passes after the change? The https://github.com/apache/iceberg-rust/pull/1266#issuecomment-2833715169 mentions to fix namespace_exists, but I don't see [tests](https://github.com/apache/iceberg-rust/blob/30181383a7d8684b08b0fba34821e82c5669dd45/crates/catalog/rest/tests/rest_catalog_test.rs) against this interface (we do have get_namespace) Yes, it would be better if we have added some integration tests when fixing it. > The reason I mention kubernetes envtest is, I imagine there could be a similar test infrastructure for iceberg rest catalog, which I'm not aware of. No, iceberg rest catalog is just a spec, and we only use docker to setup a ref implementation. You can find uts here: https://github.com/apache/iceberg-rust/blob/f162400af948628ab6f25ddf6b148ed87662328e/crates/catalog/rest/src/catalog.rs#L886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
