dentiny commented on issue #1270: URL: https://github.com/apache/iceberg-rust/issues/1270#issuecomment-2835687797
Hi @liurenjie1024 / @Xuanwo , thank you so much for your help and response! And also apology for the confusion. My question is: - Since https://github.com/apache/iceberg-rust/pull/1266 is a bug fix, is it possible to add a unit test / integration test, which fails before the change, but passes after the change? - The [PR](https://github.com/apache/iceberg-rust/pull/1266#issuecomment-2833715169) mentions to fix `namespace_exists`, but I don't see [tests](https://github.com/apache/iceberg-rust/blob/30181383a7d8684b08b0fba34821e82c5669dd45/crates/catalog/rest/tests/rest_catalog_test.rs) against this interface (we do have `get_namespace`) - Thanks for the test code pointer! It looks like we're rely on docker for **integration test**, I'm more curious if you guys have recommendation / you know to **unit test** rest catalog? + The reason I mention kubernetes envtest is, I imagine there **could** be a similar test infrastructure for iceberg rest catalog, which I'm not aware of. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
