RussellSpitzer commented on code in PR #12893:
URL: https://github.com/apache/iceberg/pull/12893#discussion_r2064125727
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkExecutorCache.java:
##########
@@ -193,14 +193,29 @@ public int weight() {
static class Conf {
private final SparkConfParser confParser = new SparkConfParser();
- public boolean cacheEnabled() {
+ public boolean cacheEnabled(boolean forDeletes) {
Review Comment:
I'm a little confused why cacheEnabled overrides cacheEnabledForDeletes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
